Skip to content

Conversation

@ferranbt
Copy link
Collaborator

@ferranbt ferranbt commented Dec 14, 2025

This PR cleans a few things on the docker runtime:

  • It moves the application of the overrides (user can override which images/binaries use during execution) out of the runtime since they only modify the manifest (here).
  • Fixes the component unit tests. The way it was done before, the inputs were not modified since the test framework would apply the default variables. (here).
  • Moved the logic for the interactive mode out of the docker runtime using the callback interface from Pull images in playground itself instead of docker-compose to have visibility on pull actions #232 (here). It does not make sense that the Docker runtime owns the component that deals with the visualization on the terminal.

@ferranbt ferranbt requested a review from canercidam as a code owner December 14, 2025 15:38
@canercidam canercidam merged commit 16fa0d0 into main Dec 15, 2025
8 checks passed
@canercidam canercidam deleted the ferranbt-more-runtime branch December 15, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants