Update flashblocks number contract signature #4
+5
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
force-pushed
the
update-flashblock-sig
branch
from
c4736de to
72fa569
Compare
avalonche
force-pushed
the
update-flashblock-sig
branch
from
72fa569 to
511c753
Compare
| } | ||
|
|
||
| return true | ||
| return tx.From().Cmp(bi.cfg.builderAddr) == 0 |
Member
There was a problem hiding this comment.
issue:
From() is for deposit txes only. it panics on the "normal" ones:
// From is an OP-Stack addition to the Transaction type to easily get a deposit
// transaction sender address.
// It can be difficult to create a correct signer just to extract the From field
// from a deposit transaction if the chain ID is not known.
func (tx *Transaction) From() common.Address {
if tx.Type() != DepositTxType {
panic("From() called on non-deposit transaction")
}
return tx.inner.(interface{ from() common.Address }).from()
}| binary.BigEndian.PutUint64(xfamBytes, transformedXfam) | ||
| binary.BigEndian.PutUint64(tdAttributesBytes, transformedTdAttributes) | ||
| binary.BigEndian.PutUint64(xfamBytes, xfam) | ||
| binary.BigEndian.PutUint64(tdAttributesBytes, tdAttributes) |
Member
There was a problem hiding this comment.
question:
what happens here (and why)? could you please add to the PR description?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.