-
Notifications
You must be signed in to change notification settings - Fork 12
wip: l2 images #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
wip: l2 images #42
Conversation
e58ab4b to
447a823
Compare
d26faee to
145218b
Compare
0e37839 to
e85b24d
Compare
1127cde to
dbaeecc
Compare
dbaeecc to
427002a
Compare
| @@ -0,0 +1,14 @@ | |||
| rust: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we just grab rust from debian backports this wont be necessary. I'll take care of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we would still need a way to pin rust version somehow per image type (backports or not).
|
|
||
| BuildPackages=golang | ||
| libssl-dev | ||
| rustup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to backports rust, I'll take care of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, just pls make it possible to use different versions of rust on different image kinds.
| # | ||
| # rendered by vault-agent/gomplate | ||
| # | ||
| [[- range ( ( gcp.Meta "attributes/ssh-keys" ) | strings.Split "\n" ) ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't allowing ppl to SSH in a security risk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is.
however this line makes sure that the keys are rendered only on the image built with dev profile. so, we are ok on prod images.
and on dev images, well we already allow anyone with console access in + use predefined root password. I don't think that (secret and non public) ssh keys added by vault-agent are making it any worse security-wise here.
(move snippets around to the right places)
62da9c3 to
e7954c7
Compare
(cherry picked from commit ea20da4)
ea20da4 to
cf2f4b2
Compare
implement scripts for l2 workloads building