-
Notifications
You must be signed in to change notification settings - Fork 12
L2 Cleanup #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexhulbert
wants to merge
2
commits into
trunk/l2
Choose a base branch
from
l2-cleanup
base: trunk/l2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−56
Open
L2 Cleanup #58
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -31,3 +31,11 @@ mkosi-chroot chmod 0770 /vault/secrets | |||||
| mkosi-chroot chmod 0750 /etc/vault-agent | ||||||
| mkosi-chroot chmod 0750 /etc/vault-agent/gomplate | ||||||
| mkosi-chroot sh -c "chmod 0640 /etc/vault-agent/gomplate/*" | ||||||
|
|
||||||
| # Create /etc/sysconfig for vault-agent | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion: this is not only for vault-agent, but for any systemd service that will need some secrets injected via env var.
Suggested change
|
||||||
|
|
||||||
| mkosi-chroot mkdir -p /etc/sysconfig | ||||||
|
|
||||||
| # Limit root filesystem size to 4GB | ||||||
|
|
||||||
| mkosi-chroot sed -i '1a mount -o remount,size=4G /' /init | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,5 @@ | ||
| # This file is part of systemd. | ||
| # | ||
| # systemd is free software; you can redistribute it and/or modify it under the | ||
| # terms of the GNU Lesser General Public License as published by the Free | ||
| # Software Foundation; either version 2.1 of the License, or (at your option) | ||
| # any later version. | ||
| # | ||
| # Entries in this file show the compile time defaults. Local configuration | ||
| # should be created by either modifying this file (or a copy of it placed in | ||
| # /etc/ if the original file is shipped in /usr/), or by creating "drop-ins" in | ||
| # the /etc/systemd/journald.conf.d/ directory. The latter is generally | ||
| # recommended. Defaults can be restored by simply deleting the main | ||
| # configuration file and all drop-ins located in /etc/. | ||
| # | ||
| # Use 'systemd-analyze cat-config systemd/journald.conf' to display the full config. | ||
| # | ||
| # See journald.conf(5) for details. | ||
|
|
||
| [Journal] | ||
| #Storage=auto | ||
| #Compress=yes | ||
| #Seal=yes | ||
| #SplitMode=uid | ||
| #SyncIntervalSec=5m | ||
| #RateLimitIntervalSec=30s | ||
| #RateLimitBurst=10000 | ||
| #SystemMaxUse= | ||
| #SystemKeepFree= | ||
| SystemMaxFileSize=128M | ||
| SystemMaxFiles=2 | ||
| #RuntimeMaxUse=64K | ||
| #RuntimeKeepFree= | ||
| RuntimeMaxFileSize=512K | ||
| RuntimeMaxFiles=2 | ||
| #MaxRetentionSec=0 | ||
| #MaxFileSec=1month | ||
| #ForwardToSyslog=no | ||
| #ForwardToKMsg=no | ||
| #ForwardToConsole=no | ||
| #ForwardToWall=yes | ||
| #TTYPath=/dev/console | ||
| #MaxLevelStore=debug | ||
| #MaxLevelSyslog=debug | ||
| #MaxLevelKMsg=notice | ||
| #MaxLevelConsole=info | ||
| #MaxLevelWall=emerg | ||
| #MaxLevelSocket=debug | ||
| #LineMax=48K | ||
| #ReadKMsg=yes | ||
| #Audit=yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion:
let's ditch all these if-elses whatsoever (they are no longer needed).