Skip to content

core: tx_pool not return error in MevBundles() #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ruteri wants to merge 1 commit into from
Closed

core: tx_pool not return error in MevBundles() #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/tx_pool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ func (pool *TxPool) AllMevBundles() []types.MevBundle {

// MevBundles returns a list of bundles valid for the given blockNumber/blockTimestamp
// also prunes bundles that are outdated
func (pool *TxPool) MevBundles(blockNumber *big.Int, blockTimestamp uint64) ([]types.MevBundle, error) {
func (pool *TxPool) MevBundles(blockNumber *big.Int, blockTimestamp uint64) []types.MevBundle {
pool.mu.Lock()
defer pool.mu.Unlock()

Expand Down Expand Up @@ -617,7 +617,7 @@ func (pool *TxPool) MevBundles(blockNumber *big.Int, blockTimestamp uint64) ([]t
}

pool.mevBundles = bundles
return ret, nil
return ret
}

// AddMevBundle adds a mev bundle to the pool
Expand Down
4 changes: 2 additions & 2 deletions light/txpool.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -553,8 +553,8 @@ func (pool *TxPool) RemoveTx(hash common.Hash) {

// MevBundles returns a list of bundles valid for the given blockNumber/blockTimestamp
// also prunes bundles that are outdated
func (pool *TxPool) MevBundles(blockNumber *big.Int, blockTimestamp uint64) ([]types.Transactions, error) {
return nil, nil
func (pool *TxPool) MevBundles(blockNumber *big.Int, blockTimestamp uint64) []types.Transactions {
return nil
}

// AddMevBundle adds a mev bundle to the pool
Expand Down
7 changes: 1 addition & 6 deletions miner/worker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,12 +1263,7 @@ func (w *worker) fillTransactions(interrupt *int32, env *environment) error {
}
}
if w.flashbots.isFlashbots && !w.flashbots.isMegabundleWorker {
bundles, err := w.eth.TxPool().MevBundles(env.header.Number, env.header.Time)
if err != nil {
log.Error("Failed to fetch pending transactions", "err", err)
return err
}

bundles := w.eth.TxPool().MevBundles(env.header.Number, env.header.Time)
bundleTxs, bundle, numBundles, err := w.generateFlashbotsBundle(env, bundles, pending)
if err != nil {
log.Error("Failed to generate flashbots bundle", "err", err)
Expand Down