-
Notifications
You must be signed in to change notification settings - Fork 58
per-transaction trace log specification #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+137
−14
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b95fdd0
txn trace flags
yashvardhan-kukreja c572397
additional txn trace flags
yashvardhan-kukreja c1ba578
shift the log level to trace
yashvardhan-kukreja fa51ac4
shift the log level to debug
yashvardhan-kukreja 2b2744b
remove redundant TX_TRACE
yashvardhan-kukreja 74dbef4
fix flashblock index when no txpool
yashvardhan-kukreja cfff83d
shift monitoring logs to tx_trace
yashvardhan-kukreja dfc7773
shift monitoring logs to trace level
yashvardhan-kukreja d17a13c
shift to debug level
yashvardhan-kukreja def8bb6
env var guard rail to tx_trace logs
yashvardhan-kukreja 6079c39
nit: lint
yashvardhan-kukreja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a redundant log with the log below, if you like to filter by target = tx_trace, could consider updating all the target=monitoring tx logs to target=tx_trace? discarded tx logs would also be helpful here I think, and reduces redundant logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I thought of that but didn't want my changes to be intrusive. Happy to make that change if you re ok with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got done. Note: I got rid of
kindtag in favor ofstage