fix: ensure tcp keep-alive packets are sent #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SozinM
reviewed
Dec 2, 2025
| if let Some(stream) = stream { | ||
| #[cfg(target_os = "linux")] | ||
| unsafe { | ||
| libc::setsockopt( |
Contributor
There was a problem hiding this comment.
Also is there are any safety assumptions?
Should keep_alive_interval always be > 0?
Or be specific type?
Member
Author
There was a problem hiding this comment.
extracted the logic into separate function:
if keepalive setting is zero, then we assume no keepalive
0x416e746f6e
force-pushed
the
fix/ensure-tcp-keepalives
branch
from
174488c to
961a4d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on some systems tcp keep-alive must be enabled per-connection