Save and load#14
Merged
flashonfire merged 4 commits intoflashonfire:mainfrom Nov 21, 2025
Merged
Conversation
…rofile manager # Conflicts: # waypaper_engine_daemon/src/wl_renderer.rs
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the IPC system to distinguish between external and internal requests using the subenum crate, adds a profile manager for persisting wallpaper configurations, and migrates from crossbeam channels to standard library mpsc channels.
Key changes:
- Introduces
InternalRequestenum withsubenumto generateIPCRequestas a subset, enabling internal-only messages likeNewOutput - Adds
ProfileManagerto save/load wallpaper configurations per screen - Replaces
crossbeam::channelwithstd::sync::mpscthroughout the daemon
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| waypaper_engine_shared/src/lib.rs | Simplifies import by using env directly instead of std::env |
| waypaper_engine_shared/src/ipc.rs | Introduces InternalRequest enum using subenum to differentiate from public IPCRequest |
| waypaper_engine_shared/Cargo.toml | Adds subenum dependency for enum subset generation |
| waypaper_engine_daemon/src/wl_renderer.rs | Migrates from crossbeam to std::sync::mpsc and integrates InternalRequest |
| waypaper_engine_daemon/src/profile_manager.rs | New module for persisting wallpaper configurations to JSON file |
| waypaper_engine_daemon/src/main.rs | Adds profile_manager module declaration |
| waypaper_engine_daemon/src/app_state.rs | Refactors IPC handling to use InternalRequest, extracts set_wallpaper method, integrates profile persistence |
| Cargo.lock | Updates dependency versions including syn, quote, proc-macro2, and adds subenum |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 16 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d0b91c8 to
76d2378
Compare
flashonfire
requested changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features :