Reload systemd-networkd.service during ensure-sysext #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports sysexts that configure networkd (for example, tailscale)
2 tasks
Member
|
Hey, thanks for opening this PR. We want to get rid of these Flatcar-specific workarounds by having vanilla systemd-sysext do more. It can already do the daemon reload which we added for this. For your use case I want to add a field for service restart/reload to the extension-release metadata file. I wonder if a restart of networkd would also work instead of a reload but maybe it's good anyway to support both. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports sysexts that configure networkd (for example, tailscale)
Certain sysext extensions, such as tailscale, need to configure networkd (for example, making
tailscale*interfaces unmanaged).Testing done
ensure-sysextwith the aboveExecStarttailscale.rawfrom this MR: Fix tailscale sysext-bakery#106systemd-networkd.servicelogs to see that it was reconfigured beforetailscale0interface came up.