-
Notifications
You must be signed in to change notification settings - Fork 80
dev-db/etcd: Replace our etcdctl package with Gentoo's etcd package #3559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chewi
wants to merge
1
commit into
main
Choose a base branch
from
chewi/etcd
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `server` USE flag avoids including that binary. The client tools now include etcdutl for performing defragmentation and snapshot restoration on local data. We previously built etcdctl with `CGO_ENABLED=0`, apparently for consistency when cross-compiling, but we have since fixed that. Gentoo's package is not currently keyworded for arm64, but we can address that later. It's also a little outdated, but still much newer than ours, and we can address that later too. Closes: flatcar/Flatcar#1932 Signed-off-by: James Le Cuirot <jlecuirot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace our etcdctl package with Gentoo's etcd package
A
serverUSE flag avoids including that binary. The client tools now include etcdutl for performing defragmentation and snapshot restoration on local data.We previously built etcdctl with
CGO_ENABLED=0, apparently for consistency when cross-compiling, but we have since fixed that.Gentoo's package is not currently keyworded for arm64, but we can address that later. It's also a little outdated, but still much newer than ours, and we can address that later too.
Closes: flatcar/Flatcar#1932
How to use
Fire up the image and check the binaries basically work. Kola should cover it though.
Testing done
I have manually checked that the binaries show help text. Kola passed.
I'm not sure whether we really need the additional etcdutl binary, but it has only grown /usr by about 4MB (compressed). If you think it's not needed, let me know, and I can
INSTALL_MASKit.changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.