Protect against exception when onpopstate/onhashchange are null

[steveluscher]

Without this patch, the following will throw an exception:

router = Router(routes)
router.configure({
  notfound: function() { router.setRoute('/'); }
});
router.init();

In the early stages of page load, window.onpopstate and window.onhashchange are null (in Chrome, anyway).

[steveluscher]

Erm… actually, this still prevents the handler for / in my example from running. What's the proper way to redirect when a route is not found?

[ogradyjd]

So far as I know, and I've been using director since it was sugarskull, it looks that you should just set the window.location.hash to the route you want. In this case, your code would be:

router.configure({
    notfound: function() {  window.location.hash = '' }
});

Director will pick this up in the hash onChange event and route on it.

[steveluscher]

But I suppose this won't work if you're trying to use Director in html5history mode.

[ogradyjd]

No. as far as I know, you'd need to do something like this if you are using history:

window.history.pushState(“object or string”, “Title”, “/another-new-url”);

Considering that IE only started supporting pushState and the related methods in version 10, I'm staying away from history mode for a while longer. I'm not even sure that Director supports pushstate well enough to give you deep linking - for that, you need to change the hash with the third parameter in the above call.

[beaugunderson]

It looks like #229 is also an attempt to fix this issue.