Skip to content

Handle Boolean attributes (e.g. 'checked', 'selected') #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Solinx wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle Boolean attributes (e.g. 'checked', 'selected') #127

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
05133fa
Handle Boolean attributes
Solinx Jul 30, 2015
a8bc702
Minor efficiency improvement to boolean attr check
Solinx Jul 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion lib/plates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,17 @@ function matchClosing(input, tagname, html) {
// separators. So we need to detect these elements based on the tag name.
//
selfClosing: /^(area|base|br|col|command|embed|hr|img|input|keygen|link|meta|param|source|track|wbr)$/,


//
// Boolean Attributes - attributes that require no value
//
booleanAttr: ['allowfullscreen','async','autofocus','autoplay','checked','compact','controls',
'declare','default','defaultchecked','defaultmuted','defaultselected','defer','disabled',
'draggable','enabled','formnovalidate','hidden','indeterminate','inert','ismap','itemscope',
'loop','multiple','muted','nohref','noresize','noshade','novalidate','nowrap','open',
'pauseonexit','readonly','required','reversed','scoped','seamless','selected','sortable',
'spellcheck','translate','truespeed','typemustmatch','visible'],

//
// ### function hasClass(str, className)
// #### @str {String} the class attribute
Expand Down Expand Up @@ -327,6 +337,13 @@ function matchClosing(input, tagname, html) {
} else {
newdata = fetch(data, mapping, value, tagbody, key);
}

//
// remove a Boolean attribute if the value evaluates to false
//
if (!newdata && Merge.prototype.booleanAttr.indexOf(key.toLowerCase()) != -1) {
return '';
}

return key + '="' + (newdata || '') + '"';
} else if (!mapping.replace && mapping.attribute === key) {
Expand Down