Skip to content

Conversation

@edmulraney
Copy link
Contributor

Why?

The Fleek SDK browser build tries to access the process global variable and fails. It shouldn't assume the consumer has pollyfilled node as the consumer is a browser platform.

How?

  • Done: check process is defined before accessing it

Contribution checklist?

  • The commit messages are detailed
  • The build command runs locally
  • Assets or static content are linked and stored in the project
  • You have manually tested
  • You have provided tests

Security checklist?

  • Sensitive data has been identified and is being protected properly
  • Injection has been prevented (parameterized queries, no eval or system calls)

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2025

🦋 Changeset detected

Latest commit: 7ab8f79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@fleek-platform/sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@punkbit punkbit merged commit d72f305 into fleek-platform:develop Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants