Update no-frame-window.py to resolve deprecation warnings #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolved the following deprecation warnings: window_title_bar_hidden() window_title_bar_buttons_hidden() window_close()
ndonkoHenri
reviewed
Sep 12, 2024
| @@ -19,10 +19,11 @@ def main(page: Page): | |||
| ), | |||
| expand=True, | |||
| ), | |||
| IconButton(icons.CLOSE, on_click=lambda _: page.window_close()), | |||
| # Use the updated method to close the window | |||
There was a problem hiding this comment.
You dont need to add comments saying this 😅
ndonkoHenri
reviewed
Sep 12, 2024
| def main(page: Page): | ||
| page.window_title_bar_hidden = True | ||
| page.window_title_bar_buttons_hidden = True | ||
| # Use the updated properties for window title bar settings |
ndonkoHenri
reviewed
Sep 12, 2024
| @@ -19,10 +19,11 @@ def main(page: Page): | |||
| ), | |||
| expand=True, | |||
| ), | |||
| IconButton(icons.CLOSE, on_click=lambda _: page.window_close()), | |||
| # Use the updated method to close the window | |||
| IconButton(icons.CLOSE, on_click=lambda _: page.window.close()), | |||
There was a problem hiding this comment.
Suggested change
| IconButton(icons.CLOSE, on_click=lambda _: page.window.close()), | |
| IconButton(icons.CLOSE, on_click=lambda e: page.window.close()), |
Let's have e there just for good practice.
|
sorry about comments, its habit. I will try to remember 👍 |
|
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved the following deprecation warnings:
window_title_bar_hidden()
window_title_bar_buttons_hidden()
window_close()