v1: Canvas.capture() and GestureDetector right-click pan updates.
#5444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other canvas changes: - canvas drawing is clipped - canvas size is stretched to maximum if `expand` is set
…ate`, `on_right_pan_end`
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Deploying flet-docs with
|
| Latest commit: |
15af0f9
|
| Status: | 🚫 Build failed. |
ndonkoHenri
reviewed
Jul 15, 2025
Comment on lines
+303
to
+304
| Event handler argument is of type | ||
| [`PointerEvent`](https://flet.dev/docs/reference/types/PointerEvent). |
There was a problem hiding this comment.
doesn't need to be specified anymore, as discussed.
ndonkoHenri
reviewed
Jul 15, 2025
| @@ -50,6 +50,7 @@ class PageMediaData: | |||
| padding: Padding | |||
There was a problem hiding this comment.
While at it, can you please document the properties here directly?
ndonkoHenri
reviewed
Jul 15, 2025
| paint: Optional[Paint] = None | ||
| """ | ||
| A paint to composite the image into canvas. The value of this property | ||
| is the instance of [`Paint`](https://flet.dev/docs/reference/types/paint) class. |
There was a problem hiding this comment.
The type and default values of properties shouldnt be specified in the docstring, as discussed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5434
Summary by Sourcery
Enable canvas capture and image shape support, add right-click pan events to GestureDetector, integrate custom Msgpack encoder, and apply various utility and housekeeping improvements
New Features:
Enhancements: