chore: File name renamings #5843
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sdk/python/packages/flet/integration_tests/controls/material/golden/macos/reorderable_list_view/basic.png # sdk/python/packages/flet/integration_tests/controls/material/golden/macos/snack_bar/basic.png # sdk/python/packages/flet/integration_tests/controls/material/golden/macos/time_picker/basic.png # sdk/python/packages/flet/integration_tests/controls/material/test_reorderable_list_view.py # sdk/python/packages/flet/integration_tests/controls/material/test_snack_bar.py
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Copilot finished reviewing on behalf of
ndonkoHenri
November 21, 2025 13:01
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test function names across integration test files to follow a more consistent naming convention, removing redundant prefixes that duplicate the module/file name. The changes also update screenshot references to use request.node.name for dynamic naming and make minor code formatting improvements.
Key Changes:
- Test function names simplified by removing redundant prefixes (e.g.,
test_date_picker_basic→test_basic) - Screenshot references updated to use
request.node.namefor dynamic naming - Minor code formatting improvements (e.g., using
controls=keyword argument) - Addition of corresponding golden reference image files
Reviewed Changes
Copilot reviewed 30 out of 99 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_date_picker_theme.py | Renamed test function from test_date_picker_theme to test_theme_1 and updated screenshot reference |
| test_vertical_divider.py | Renamed test functions to test_basic and test_properties, updated screenshot references |
| test_textfield.py | Renamed tests removing "with_" prefix (e.g., test_with_label → test_label) |
| test_text_button.py | Renamed test_text_button_basic to test_basic |
| test_submenu_button.py | Renamed test_submenu_button_basic to test_basic |
| test_range_slider.py | Renamed test_range_slider to test_basic |
| test_outlined_button.py | Renamed test_outlined_button_basic to test_basic |
| test_menu_bar.py | Updated screenshot references from full names to "basic" and "basic_open" |
| test_list_view.py | Renamed tests removing "list_view_" prefix |
| test_list_tile.py | Updated to use controls= keyword argument for better readability |
| test_grid_view.py | Renamed tests removing "grid_view_" prefix |
| test_filled_tonal_button.py | Renamed test_filled_tonal_button_basic to test_basic |
| test_filled_button.py | Renamed test_filled_button_basic to test_basic |
| test_expansion_panel_list.py | Renamed test_expansion_panel_list_basic to test_basic |
| test_divider.py | Renamed test_divider_radius to test_radius |
| test_date_picker.py | Renamed test_date_picker_basic to test_basic, updated screenshot reference |
| test_data_table.py | Refactored to use page-level screenshots instead of Screenshot control |
| test_circle_avatar.py | Renamed tests and improved code formatting |
| test_chip.py | Renamed tests removing "chip_" prefix, updated screenshot references |
| test_card.py | Renamed test_card_basic to test_basic, improved formatting |
| test_button.py | Renamed tests removing "button_" prefix |
| test_bottom_app_bar.py | Renamed test_bottom_app_bar to test_basic |
| test_banner.py | Renamed tests removing "banner_" prefix, updated screenshot references |
| test_app_bar.py | Renamed test_app_bar to test_basic |
| test_alert_dialog.py | Renamed test_alert_dialog_basic to test_basic, minor formatting fix |
| golden/*.png | Added reference images for renamed tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying flet-docs with
|
| Latest commit: |
ade50c0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://19275c28.flet-docs.pages.dev |
| Branch Preview URL: | https://renamings.flet-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Align file names, docs references, and visual regression tests with updated naming conventions across the Python SDK and examples.
Build:
Documentation:
Tests:
controlsparameter for Column construction.