-
Notifications
You must be signed in to change notification settings - Fork 15
upload phase calculation example #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Spell Check ReportPhaseChangeAntennas.ipynb:
Checked 1 notebook(s). Found spelling errors in 1 file(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp . This is the prelude of the vortex beam generation notebook you created.
In this notebook you used PML on x and y and used the field monitor to extract the phase. I wonder if it's more common to use periodic boundary (local periodic approximation) and diffraction monitor? Is there a particular reason why you chose to use pml? I suspect both methods will give you very similar results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @Filipe! I have just two suggestions:
-
In cell 2, maybe specify what the "hemisphere" parameter does in the function
-
Maybe plotting one of the simulations before running so we can visualize the field and source setup
@tomflexcompute |
Yes I think showing both approaches would be great. |
Thanks, everyone. I’ve made the changes based on Alec’s comments and added the section using the Thanks! |
Hi all. A user asked for an example of how to calculate phase. I had this a long time ago as part of the vortex metasurface notebook .
I didn’t include it in the notebook, but I thought it would be a good idea to make a simple example for it.
Almost all comments in the code are AI-generated