-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Add SSAC notebook #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
c6c21da
to
2da5b1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @damiano-flex! This is a very informative example. A couple comments:
-
In the library import cell, you have a "# TODO REMOVE" comment there. I'm guessing you should remove the run_heat import?
-
Same thing in the cell after "Run the Simulation" - remove the "TOREMOVE" comment
-
When discussing the physical interpretation of results, remind us what W is.
-
In the conclusion, "Desigend -> Designed"
-
Please reset the kernel and rerun all cells so the cell numbers are in order.
Thank you @alec-flexcompute for the prompt review. 1-2-5) Since these simulations are quite expensive to run, I wait till the last moment to run them in the servers. So I keep the version with the local runner until it is ready to merge. 3-4) Ops. I'll take care of that. |
Also should ruff this notebook so it will pass the lint checks |
Thanks @damiano-flex ! Ran this by Gemini and it has an interesting suggestion: compare to DC theoretical capacitance
Some other comments:
|
Thanks @damiano-flex looks very good, just a few thoughts on a first pass
Out of curiosity can't remember if we can also support electroabsorption as well so say around +0.7V rather than just depletion? |
We haven't been very consistent about this - and the original idea was to add the warning only if it's more than 1FC. And the charge solver is currently always charged at the minimum cost of 0.025FC. |
@damiano-flex please edit the corresponding rst file ( Could you prepare a schematic thumbnail for the notebook? I can prepare one for you if you prefer. |
This notebook is a simple SSAC example. It is straight to the point, without excessive explanations, since it will be quite close to the PIN notebook in terms of new functionalities (other than SSAC).