-
Notifications
You must be signed in to change notification settings - Fork 66
FXC-3517 add impedance calculations to mode solver #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmarek-flex
wants to merge
6
commits into
develop
Choose a base branch
from
dmarek/add_impedance_to_mode_data
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+15,107
−8,045
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ab2f10c
feat(rf): add a MicrowaveModeSpec for RF specific mode information
dmarek-flex e9ca7aa
refactor mode spec to inheritance
dmarek-flex 931fc9b
fix when loading ModeSimulationData
dmarek-flex 05ac600
fix issues with downloading MicrowaveModeSolverData
dmarek-flex 6303deb
revisions
dmarek-flex 54e14fb
refactor path integrals into components/microwave
dmarek-flex File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
.. _microwave_migration: | ||
|
||
v2.10 Refactor Migration | ||
------------------------- | ||
|
||
In version ``v2.10.0``, microwave plugin path integral classes were renamed for improved consistency and clarity. Additionally, these classes (and the impedance calculator) were refactored out of the plugin and moved into ``tidy3d.components.microwave`` and re-exported at the top-level package for convenience. This guide helps you update your scripts to use the new class names and imports. | ||
|
||
Key Changes | ||
~~~~~~~~~~~ | ||
|
||
* **Renamed Classes**: Path integral classes have been renamed to follow a consistent naming pattern. | ||
* **New Import Path (simplified)**: The path integral classes and impedance calculator are now exported at the top level. Prefer importing directly from ``tidy3d`` (e.g., ``from tidy3d import AxisAlignedVoltageIntegral, ImpedanceCalculator``). Existing plugin imports continue to work for backwards compatibility where applicable. | ||
|
||
Class Name Changes | ||
~~~~~~~~~~~~~~~~~~ | ||
|
||
The following classes have been renamed for consistency: | ||
|
||
**Voltage Integrals:** | ||
|
||
* ``VoltageIntegralAxisAligned`` → ``AxisAlignedVoltageIntegral`` | ||
* ``CustomVoltageIntegral2D`` → ``Custom2DVoltageIntegral`` | ||
|
||
**Current Integrals:** | ||
|
||
* ``CurrentIntegralAxisAligned`` → ``AxisAlignedCurrentIntegral`` | ||
* ``CustomCurrentIntegral2D`` → ``Custom2DCurrentIntegral`` | ||
|
||
**Path Integrals:** | ||
|
||
* ``CustomPathIntegral2D`` → ``Custom2DPathIntegral`` | ||
|
||
Migration Examples | ||
~~~~~~~~~~~~~~~~~~ | ||
|
||
**Before (v2.9.x):** | ||
|
||
.. code-block:: python | ||
from tidy3d.plugins.microwave import ( | ||
VoltageIntegralAxisAligned, | ||
CurrentIntegralAxisAligned, | ||
) | ||
voltage_path = VoltageIntegralAxisAligned( | ||
center=(0, 0, 0), | ||
size=(0, 0, 1), | ||
sign="+", | ||
) | ||
current_path = CurrentIntegralAxisAligned( | ||
center=(0, 0, 0), | ||
size=(2, 1, 0), | ||
sign="+", | ||
) | ||
**After (v2.10+):** | ||
|
||
.. code-block:: python | ||
from tidy3d import ( | ||
AxisAlignedVoltageIntegral, | ||
AxisAlignedCurrentIntegral, | ||
) | ||
voltage_path = AxisAlignedVoltageIntegral( | ||
center=(0, 0, 0), | ||
size=(0, 0, 1), | ||
sign="+", | ||
) | ||
current_path = AxisAlignedCurrentIntegral( | ||
center=(0, 0, 0), | ||
size=(2, 1, 0), | ||
sign="+", | ||
) | ||
Custom 2D Path Integrals | ||
~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
**Before:** | ||
|
||
.. code-block:: python | ||
from tidy3d.plugins.microwave import ( | ||
CustomVoltageIntegral2D, | ||
CustomCurrentIntegral2D, | ||
) | ||
vertices = [[0, 0], [1, 0], [1, 1], [0, 1]] | ||
voltage_path = CustomVoltageIntegral2D( | ||
axis=2, | ||
position=0.0, | ||
vertices=vertices, | ||
) | ||
current_path = CustomCurrentIntegral2D( | ||
axis=2, | ||
position=0.0, | ||
vertices=vertices, | ||
) | ||
**After:** | ||
|
||
.. code-block:: python | ||
from tidy3d import ( | ||
Custom2DVoltageIntegral, | ||
Custom2DCurrentIntegral, | ||
) | ||
vertices = [[0, 0], [1, 0], [1, 1], [0, 1]] | ||
voltage_path = Custom2DVoltageIntegral( | ||
axis=2, | ||
position=0.0, | ||
vertices=vertices, | ||
) | ||
current_path = Custom2DCurrentIntegral( | ||
axis=2, | ||
position=0.0, | ||
vertices=vertices, | ||
) | ||
Summary | ||
~~~~~~~ | ||
|
||
All functionality remains the same—only class names and preferred import paths have changed. Update your imports to the top level (``from tidy3d import ...``) and class names according to the table above, and your code will work with v2.10. For impedance calculations, import ``ImpedanceCalculator`` directly via ``from tidy3d import ImpedanceCalculator``. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very good thanks