Skip to content

139: Split up S2Connection into a sync and async interface as well as decoupling the underlying medium e.g. websockets, mqtt and d-bus interfaces#144

Open
lfse-slafleur wants to merge 12 commits intomainfrom
139-s2connection-should-have-an-async-capable-interface-next-to-the-sync-interface
Open

139: Split up S2Connection into a sync and async interface as well as decoupling the underlying medium e.g. websockets, mqtt and d-bus interfaces#144
lfse-slafleur wants to merge 12 commits intomainfrom
139-s2connection-should-have-an-async-capable-interface-next-to-the-sync-interface

Conversation

@lfse-slafleur
Copy link
Member

No description provided.

@lfse-slafleur lfse-slafleur self-assigned this Oct 28, 2025
@lfse-slafleur lfse-slafleur changed the title 139: Moving big chunks of code places. 139: Split up S2Connection into a sync and async interface as well as decoupling the underlying medium e.g. websockets, mqtt and d-bus interfaces Oct 28, 2025
@lfse-slafleur lfse-slafleur marked this pull request as ready for review March 10, 2026 09:21
@lfse-slafleur
Copy link
Member Author

@philipptrenz I can't put you as an official reviewer but I would be very interested in your thoughts and comments. Finally had time to finish this PR and it should allow you as well as anyone else to use just the S2Connection on top of any 'medium', use it fully sync or fully async as well as allow for extension towards a CEM handler.

@jorritn @wcoenraads I don't have time to add the CEM handler similarly to the ResourceManager. PR is big enough already so perhaps we should do that separately.

@philipptrenz
Copy link
Contributor

Hi @lfse-slafleur, great thanks. Will have a detailed look, however will probably be only after next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S2Connection should have an async-capable interface next to the sync-interface Generic S2Connection base class Redesign of the S2Connection class

2 participants