Open
Conversation
chima222
force-pushed
the
cma1/add-append-items-method
branch
from
8e7243e to
e3f557d
Compare
june-sky
reviewed
Oct 14, 2025
| items: T::Array[Item] | ||
| ).void | ||
| end | ||
| def append_items(table_name, items) |
There was a problem hiding this comment.
please add unit tests for this method
june-sky
reviewed
Oct 14, 2025
june-sky
left a comment
june-sky
left a comment
There was a problem hiding this comment.
Your feature is just sending some metric data to gsheet; it has no relate to the quarantine gem itself. It is not recommended to use this gem for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background:
write_items method in old google_sheets.rb will override all datas in a sheet, but I need an append-only method for recording CI/CD data.
Changes:
add append only method for google sheet