Skip to content

Define == for DeviceInfo#233

Open
hramrach wants to merge 1 commit intoflipperdevices:devfrom
hramrach:dev
Open

Define == for DeviceInfo#233
hramrach wants to merge 1 commit intoflipperdevices:devfrom
hramrach:dev

Conversation

@hramrach
Copy link
Contributor

@hramrach hramrach commented Apr 8, 2025

Looks like some newer Qt versions require == instead of !=.

Define both.

Looks like some newer Qt versions require == instead of !=.

Define both.
@ArchangeGabriel
Copy link

Can confirm, this is the build failure without this:

In file included from moc_deviceinfo.cpp:12:
/usr/include/qt6/QtCore/qtmochelpers.h: In instantiation of ‘bool QtMocHelpers::setProperty(Prop&, Value&&) [with Prop = Flipper::Zero::HardwareInfo; Value = Flipper::Zero::HardwareInfo&]’:
moc_deviceinfo.cpp:333:42:   required from here
  333 |         case 5: QtMocHelpers::setProperty(_t->hardware, *reinterpret_cast<Flipper::Zero::HardwareInfo*>(_v)); break;
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/qt6/QtCore/qtmochelpers.h:123:18: error: no match foroperator==’ (operand types are ‘Flipper::Zero::HardwareInfo’ and ‘Flipper::Zero::HardwareInfo’)
  123 |     if (property == value)
      |         ~~~~~~~~~^~~~~~~~
/usr/include/qt6/QtCore/qtmochelpers.h: In instantiation of ‘bool QtMocHelpers::setProperty(Prop&, Value&&) [with Prop = Flipper::Zero::SoftwareInfo; Value = Flipper::Zero::SoftwareInfo&]’:
moc_deviceinfo.cpp:334:42:   required from here
  334 |         case 6: QtMocHelpers::setProperty(_t->firmware, *reinterpret_cast<Flipper::Zero::SoftwareInfo*>(_v)); break;
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/qt6/QtCore/qtmochelpers.h:123:18: error: no match foroperator==’ (operand types are ‘Flipper::Zero::SoftwareInfo’ and ‘Flipper::Zero::SoftwareInfo’)
  123 |     if (property == value)
      |         ~~~~~~~~~^~~~~~~~
/usr/include/qt6/QtCore/qtmochelpers.h: In instantiation of ‘bool QtMocHelpers::setProperty(Prop&, Value&&) [with Prop = Flipper::Zero::StorageInfo; Value = Flipper::Zero::StorageInfo&]’:
moc_deviceinfo.cpp:335:42:   required from here
  335 |         case 7: QtMocHelpers::setProperty(_t->storage, *reinterpret_cast<Flipper::Zero::StorageInfo*>(_v)); break;
      |                 ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/qt6/QtCore/qtmochelpers.h:123:18: error: no match foroperator==’ (operand types are ‘Flipper::Zero::StorageInfo’ and ‘Flipper::Zero::StorageInfo’)
  123 |     if (property == value)
      |         ~~~~~~~~~^~~~~~~~

@probatas
Copy link

Tanzania

thican added a commit to thican/pentoo-overlay that referenced this pull request Jul 9, 2025
Source upstream:
flipperdevices/qFlipper#233

Closes: https://bugs.gentoo.org/959273
Signed-off-by: Thibaud CANALE <thican@thican.net>
kowalski7cc added a commit to flathub/one.flipperzero.qFlipper that referenced this pull request Sep 14, 2025
runtime: Update Platform to 6.9 with patch from pull flipperdevices/qFlipper#233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants