fix(cache): trim <> from email keys#1190
Merged
andrinoff merged 1 commit intofloatpane:masterfrom Apr 29, 2026
Merged
Conversation
Resolves floatpane#1122. Email addresses arriving from `From:` headers commonly come wrapped in angle brackets (`<foo@bar.com>`). The previous trim cutset was `","`, so the cache stored the literal `<foo@bar.com>` and never matched future lookups against `foo@bar.com`. Add `<` and `>` to the trim cutset so the cache key is the bare address regardless of whether the input came from a header or a UI field. Whitespace and commas continue to be trimmed.
floatpanebot
previously requested changes
Apr 29, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @mvanhorn! Please fix the following issues with your PR:
- Title: Is too long (57 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
mvanhorn
changed the title
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
Contributor
Author
|
Updated title to |
Member
|
/approve |
floatpanebot
approved these changes
Apr 29, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Approved on behalf of @andrinoff via /approve command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add
<and>to the trim cutset innormalizeContactEmailso the cache key is the bare email regardless of whether the input came from a header or a UI field. Whitespace and commas continue to be trimmed.Why?
Email addresses arriving from
From:headers commonly come wrapped in angle brackets (<foo@bar.com>). The previous trim cutset was,only, so the cache stored the literal<foo@bar.com>and never matched future lookups againstfoo@bar.com.Resolves #1122.