fix(i18n): wrap error in loader#1202
Merged
andrinoff merged 1 commit intofloatpane:masterfrom Apr 30, 2026
Merged
Conversation
andrinoff
approved these changes
Apr 30, 2026
Member
andrinoff
left a comment
andrinoff
left a comment
There was a problem hiding this comment.
lgtm, but @Haroka-74 , please pick up non good first issues too, we try to leave the good first issues for newcomers
Contributor
Author
|
Totally understand. I’m still relatively new to the Go ecosystem, so I started with some good first issues to get familiar with the codebase and workflow. I’ll focus more on non good first issues going forward. |
Member
|
/approve |
floatpanebot
approved these changes
Apr 30, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Approved on behalf of @andrinoff via /approve command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Replaced the
%vverb with%wini18n/loader.gowhen returning errors from the embedded loader.Why?
The current implementation stringifies the underlying
errusing%v, which breaks the error chain. This prevents callers from inspecting the root cause usingerrors.Is()orerrors.As(). Utilizing double%w(supported in Go 1.20+) ensures bothErrLoadFailedand the original error remain accessible in the error tree.Closes #1051