Open
Conversation
Owner
|
very nice! I think when I was developing this package this option did not exist yet, I was looking for exactly that. were you able to run a unit test for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for publishing this package!
When using a large number of parameters, the current hack to sampling from a truncated distribution would require an unreasonably large number of iterations, so I made this minor change to use the truncated functionality built-in to Distributions.jl
Let me know if this seems reasonable. I'm happy to make any other necessary changes for it to be acceptable.
Thanks,
Oliver