-
Notifications
You must be signed in to change notification settings - Fork 1
feature: OG tag 설정 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes made to Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
public/og_tag.pngis excluded by!**/*.png
📒 Files selected for processing (1)
index.html(1 hunks)
🔇 Additional comments (1)
index.html (1)
13-16: Consider these improvements for better social media sharing
- Add the
og:typemeta tag (e.g.,websitefor generic web pages) - Consider adding
og:image:widthandog:image:heightfor optimal social media previews - Consider adding
og:site_nameto distinguish the brand
Here's a suggested implementation:
<meta property="og:title" content="플로우빗" />
<meta property="og:description" content="데이터 속 예측력, LSTM과 GPT가 선사하는 비트코인 추세 예측" />
- <meta property="og:image" content="/og_tag.png" />
+ <meta property="og:image" content="https://www.flowbit.co.kr/og_tag.png" />
+ <meta property="og:image:width" content="1200" />
+ <meta property="og:image:height" content="630" />
<meta property="og:url" content="https://www.flowbit.co.kr/" />
+ <meta property="og:type" content="website" />
+ <meta property="og:site_name" content="플로우빗" />Let's verify if the og_tag.png exists in the repository:
✅ Verification successful
Update Open Graph image path and add recommended meta tags
The og_tag.png exists at public/og_tag.png, confirming the need for these improvements:
- Use absolute URL for
og:imageto ensure proper social media previews - Add recommended Open Graph meta tags for better social sharing
Here's the verified suggestion:
<meta property="og:title" content="플로우빗" />
<meta property="og:description" content="데이터 속 예측력, LSTM과 GPT가 선사하는 비트코인 추세 예측" />
- <meta property="og:image" content="/og_tag.png" />
+ <meta property="og:image" content="https://www.flowbit.co.kr/og_tag.png" />
+ <meta property="og:image:width" content="1200" />
+ <meta property="og:image:height" content="630" />
<meta property="og:url" content="https://www.flowbit.co.kr/" />
+ <meta property="og:type" content="website" />
+ <meta property="og:site_name" content="플로우빗" />🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if og_tag.png exists in the repository
fd -t f "og_tag.png"
Length of output: 38
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <meta property="og:title" content="플로우빗" /> | ||
| <meta property="og:description" content="데이터 속 예측력, LSTM과 GPT가 선사하는 비트코인 추세 예측" /> | ||
| <meta property="og:image" content="/og_tag.png" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the og:image URL to use absolute path
The current relative path /og_tag.png won't work properly with social media platforms. They require absolute URLs to fetch the image.
Apply this change:
- <meta property="og:image" content="/og_tag.png" />
+ <meta property="og:image" content="https://www.flowbit.co.kr/og_tag.png" />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <meta property="og:image" content="/og_tag.png" /> | |
| <meta property="og:image" content="https://www.flowbit.co.kr/og_tag.png" /> |
klmhyeonwoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🙋 Summary (요약)
🤔 Describe your Change (변경사항)
🔗 Issue number and link (참고)
Summary by CodeRabbit