Skip to content

feat(data-pathways): add optional sourceId to SendPumpPulseCommand#219

Merged
jbiskur merged 1 commit intomainfrom
feat/pump-pulse-source-id
Apr 24, 2026
Merged

feat(data-pathways): add optional sourceId to SendPumpPulseCommand#219
jbiskur merged 1 commit intomainfrom
feat/pump-pulse-source-id

Conversation

@jbiskur
Copy link
Copy Markdown
Contributor

@jbiskur jbiskur commented Apr 23, 2026

Summary

  • Add optional sourceId?: string to SendPumpPulseInput
  • Additive / non-breaking — callers that don't set it are unaffected

Why

The data-pathways control-plane accepts sourceId in its /api/v1/pump-pulse route's Zod schema but the SDK input type never exposed it. Downstream (@flowcore/data-pump's PulseEmitter) therefore can't thread per-source identity into pulses. Result: every pulse lands on a single NULL-sourceId row per flowType in pump_pulses, shadowing any correctly-keyed sibling.

This is the first of three PRs; the matching changes live in @flowcore/data-pump (new pulse.sourceId option) and the data-pathways worker (pass source.id into buildPump).

Test plan

  • deno check src/mod.ts clean
  • Reviewer confirms release-please bumps as patch (3.3.03.3.1)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor
    • Enhanced internal data handling capabilities by introducing an optional identifier parameter, enabling improved data pathway functionality without affecting existing operations.

Threads source identity through the pump-pulse contract so callers can
distinguish pulses from different sources on the same pathway+flowType.
The server (data-pathways control-plane) already accepts this field in
its Zod schema; without it, all pulses land on a single NULL-sourceId
row per flowType and shadow any non-null siblings.

Additive-only — no body-shape change for existing callers.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e25f9f8a-4311-4e1c-9f4b-fb6d1693e8b6

📥 Commits

Reviewing files that changed from the base of the PR and between acf8488 and 5f9b23c.

📒 Files selected for processing (1)
  • src/commands/data-pathways/pump-pulse.send.ts

📝 Walkthrough

Walkthrough

The SendPumpPulseInput interface in the pump-pulse command module is extended with an optional sourceId field, enabling callers to optionally provide an additional identifier for source tracking without breaking existing usage.

Changes

Cohort / File(s) Summary
Interface Extension
src/commands/data-pathways/pump-pulse.send.ts
Added optional sourceId?: string property to the SendPumpPulseInput interface.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A little field, so small and neat,
One tiny source to make complete,
The pump-pulse pulses, now with grace,
An optional string finds its place!
thump-thump goes the rabbit's heart! 💚

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an optional sourceId field to SendPumpPulseCommand, which directly aligns with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pump-pulse-source-id

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jbiskur jbiskur merged commit 2eee75a into main Apr 24, 2026
2 checks passed
@jbiskur jbiskur deleted the feat/pump-pulse-source-id branch April 24, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant