feat(data-pathways): add optional sourceId to SendPumpPulseCommand#219
feat(data-pathways): add optional sourceId to SendPumpPulseCommand#219
Conversation
Threads source identity through the pump-pulse contract so callers can distinguish pulses from different sources on the same pathway+flowType. The server (data-pathways control-plane) already accepts this field in its Zod schema; without it, all pulses land on a single NULL-sourceId row per flowType and shadow any non-null siblings. Additive-only — no body-shape change for existing callers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
sourceId?: stringtoSendPumpPulseInputWhy
The data-pathways control-plane accepts
sourceIdin its/api/v1/pump-pulseroute's Zod schema but the SDK input type never exposed it. Downstream (@flowcore/data-pump'sPulseEmitter) therefore can't thread per-source identity into pulses. Result: every pulse lands on a single NULL-sourceId row per flowType inpump_pulses, shadowing any correctly-keyed sibling.This is the first of three PRs; the matching changes live in
@flowcore/data-pump(newpulse.sourceIdoption) and the data-pathways worker (passsource.idintobuildPump).Test plan
deno check src/mod.tsclean3.3.0→3.3.1)🤖 Generated with Claude Code
Summary by CodeRabbit