Draft
Conversation
This fixes two issues: - `path.Clean(…)` would transform a path like `C:\User\john\bar` to just `.` – fixed with `filepath.Clean()` - The check for the filesystem root using `/` never works on Windows, as there it is e.g. `C:\` – check for an "unchanged parent" instead
kdambekalns
commented
Oct 23, 2024
| return | ||
| } | ||
|
|
||
| Base = filepath.Join(homeDir, ".LocalBeach") |
Member
Author
There was a problem hiding this comment.
Probably nonsense to use the ., as that is still visible on Windows. Maybe use UserConfigDir instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to use the
beachcommand on a Windows machine, as long asdockeris available (e.g. via an installation of Docker Desktop).