Fixed crash on large binary files #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great work on building this project! I recently discovered that committing large binary files can still cause a crash. Upon further investigation, I found that the issue stems from the binary data being encoded as text within the patch string.
To address this issue, I propose removing the unnecessary encoding of binary data before slicing the array for processing by ChatGPT. This should effectively prevent the crash when committing large files.
While this approach may prioritize binary files over other changes due to the commit list being sorted by length, the same issue can occur with large code changes. To further improve the function, we could consider sending a request to OpenAI for each
diff --gitcommand and then combining the results to build the summary later. This would help to avoid dismissing significant changes based solely on their length and ensure that changes are ranked by relevance.