Skip to content

Add FlakeUpdate command #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023
Merged

Add FlakeUpdate command #50

merged 1 commit into from
Aug 14, 2023

Conversation

OliverEvans96
Copy link
Contributor

@OliverEvans96 OliverEvans96 commented Aug 10, 2023

Closes #47.

I basically just copied and pasted the FlakeMetadata implementation. I imagine at some point the flake subcommands might be refactored into their own namespace, but it seems appropriate to just submit the simplest PR first.

As a side-node: As I was testing, I needed to have the PARSER_UTIL_BIN env var set to build successfully. Is this binary dependency new since the latest released version? I was able to get it working by snooping around your nix files, but it seems like it might be somewhat of a barrier to adoption. Maybe it could at least be discussed in the readme.

Let me know if you'd like any changes to the PR.

Thanks,
Oliver

@ysndr
Copy link
Contributor

ysndr commented Aug 14, 2023

Hej Oliver, thanks for the contribution.

I agree the commands might need to organized a bit differently as we're adding on more, but for now its simple enough to just collect them in a single namespace, since they are rather mostly boilerplate as you probably noticed.

The PARSER_UTIL_BIN is a regression from our recent move to directly use nix' uri parser rather than reimplementing it. The adoption hurdles that come with it are unfortunate, and documenting them is the least we can do.

@ysndr ysndr self-requested a review August 14, 2023 12:30
@mkenigs
Copy link
Contributor

mkenigs commented Aug 14, 2023

The PARSER_UTIL_BIN is a regression from our recent move to directly use nix' uri parser rather than reimplementing it. The adoption hurdles that come with it are unfortunate, and documenting them is the least we can do.

Opened #51

@mkenigs mkenigs merged commit 5d7ce86 into flox:main Aug 14, 2023
@OliverEvans96 OliverEvans96 deleted the flake-update branch August 15, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nix flake update command
3 participants