Drop -Gst1.0 suffix from GStreamer decoder and other GStreamer references
#313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the GStreamer decoder naming by removing legacy version suffixes that originated from when both GStreamer 0.10 and 1.0 were supported. Since only GStreamer 1.0+ is now supported, the -Gst1.0 suffix is no longer meaningful.
Key changes:
- Decoder names are simplified by removing the
-Gst1.0suffix (BREAKING CHANGE) - A temporary backward compatibility workaround is added to handle old decoder names until version 1.0.0
- Documentation and references updated to remove "1.0" version specifications
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| fluster/fluster.py | Adds backward compatibility logic to strip -gst1.0 suffix from decoder names |
| fluster/decoders/gstreamer.py | Refactors all GStreamer decoder classes, removing version suffixes from names and consolidating base class properties |
| Makefile | Updates test commands to use new decoder names without -Gst1.0 suffix |
fluster/fluster.py
Outdated
| if ctx.decoders_names: | ||
| ctx.decoders_names = [x.lower() for x in ctx.decoders_names] | ||
| print(ctx.decoders_names) | ||
| # Workaound to avoid BC break for prev commit. Delete when 1.0.0 |
There was a problem hiding this comment.
Corrected spelling of 'Workaound' to 'Workaround'.
Suggested change
| # Workaound to avoid BC break for prev commit. Delete when 1.0.0 | |
| # Workaround to avoid BC break for prev commit. Delete when 1.0.0 |
rgonzalezfluendo
force-pushed
the
drop_gst1.0_suffix
branch
from
876ba05 to
7ef0ca4
Compare
mdimopoulos
force-pushed
the
drop_gst1.0_suffix
branch
from
7ef0ca4 to
a67cb5d
Compare
BREAKING CHANGE: Decoder names change losing the Gst1.0 prefix
mdimopoulos
force-pushed
the
drop_gst1.0_suffix
branch
from
a67cb5d to
572ebc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit drops all the references to 1.0 when GStreamer was supported. These references come from when GStreamer 1.0 and the legacy GStreamer 0.10 were supported.
This is a BREAKING CHANGE: Decoder names change, losing the
-Gst1.0prefix.The second commit adds a workaround to avoid breaking the BC waiting for the next major release.