Skip to content

fix: enhance missing methods to handle missing keys more explicitly i… #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: enhance missing methods to handle missing keys more explicitly i… #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions 03-dict-set/missing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@

"""

from collections import UserDict
from collections import abc
from collections import UserDict, abc


def _upper(x):
Expand All @@ -73,12 +72,16 @@ def _upper(x):

class DictSub(dict):
def __missing__(self, key):
return self[_upper(key)]
if _upper(key) in self:
return self[_upper(key)]
raise KeyError(key)


class UserDictSub(UserDict):
def __missing__(self, key):
return self[_upper(key)]
if _upper(key) in self:
return self[_upper(key)]
raise KeyError(key)


class SimpleMappingSub(abc.Mapping):
Expand All @@ -105,15 +108,19 @@ def __getitem__(self, key):
try:
return self._data[key]
except KeyError:
return self[_upper(key)]
if _upper(key) in self._data:
return self[_upper(key)]
raise KeyError(key)


class DictLikeMappingSub(SimpleMappingSub):
def __getitem__(self, key):
try:
return self._data[key]
except KeyError:
return self[_upper(key)]
if _upper(key) in self:
return self[_upper(key)]
raise KeyError(key)

def get(self, key, default=None):
return self._data.get(key, default)
Expand Down