fix: add .snyk safety net ignore for goldmark XSS#97
Merged
Conversation
goldmark v1.4.13 is a ghost transitive dep via golang.org/x/tools — not listed in go.mod and never compiled into any binary. Adding ignore for consistency with existing go-jose and x/crypto ignores. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
Adds a Snyk “safety-net” ignore entry for a reported goldmark XSS vulnerability that is present only as an unused transitive (non-compiled) dependency in the root module, aligning root policy with the existing pattern used for other ghost dependencies.
Changes:
- Add
.snykignore forSNYK-GOLANG-GITHUBCOMYUINGOLDMARKRENDERHTML-15838406(CVE-2026-5160) with rationale and time-bounded expiration.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrecastillo
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.snyksafety-net ignore for goldmark XSS vulnerability (CVE-2026-5160,SNYK-GOLANG-GITHUBCOMYUINGOLDMARKRENDERHTML-15838406)github.com/yuin/goldmark@v1.4.13is a ghost transitive dependency viagolang.org/x/tools@v0.44.0— not listed ingo.modand never compiled into any binarygo mod whyconfirms: "main module does not need package github.com/yuin/goldmark"Context
JIRA FL-29335 (goldmark XSS in
_examples/go.mod) is still open, while the identical FL-29336 (go.mod) is already DONE. Both are ghost deps with no vulnerable code paths.golang.org/x/tools@v0.44.0(latest) still requires goldmark v1.4.13 — no upstream fix available yet.Verification
snyk test --org=flumepasses with 0 vulnerabilities (bothgo.modand_examples/go.mod)go test ./passescd _examples && go test ./.passesTest plan
🤖 Generated with Claude Code