Support render texture for Vulkan+Impeller #129

xiaowei-guan · 2025-11-12T09:44:27Z

If want to render texture with Vulakn + Impeller, you should apply this flutter-tizen/flutter#17

* modify_code * Type conversion * code format

xiaowei-guan · 2025-11-14T09:42:52Z

1.Add GetDevice method insted of device_ variable. 2.Refactor variable name for pixel buffer. 3.Add GetMemoryFDProperty method insted of variable.

xiaowei-guan · 2025-12-05T06:26:46Z

@JSUYA Do you have time to review this PR?

JSUYA · 2025-12-05T06:31:55Z

@JSUYA Do you have time to review this PR?

I'll start soon

JSUYA

When I tested with video_player, app has crashed. please check it out.

plugins/packages/video_player/example (master) 17:52:58 $ flutter-tizen run --enable-impeller --dart-define=USE_FLUTTER_TIZEN_EXPERIMENTAL=true
Launching tizen/flutter/generated_main.dart on Tizen rpi4 in debug mode...
The platform profile is used for signing.
Building a Tizen application in debug mode...                      12.2s
✓ Built build/tizen/tpk/org.tizen.video_player_tizen_example-1.0.0.tpk (40.1MB)
Installing build/tizen/tpk/org.tizen.video_player_tizen_example-1.0.0.tpk...        17.8s
[E] [WARNING:flutter/impeller/renderer/backend/vulkan/driver_info_vk.cc(263)] Unknown GPU Driver Vendor: 5348. This is not an error.
[E] [IMPORTANT:flutter/shell/platform/embedder/embedder_surface_vulkan_impeller.cc(80)] Using the Impeller rendering backend (Vulkan).
Syncing files to device Tizen rpi4...                               55ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

A Dart VM Service on Tizen rpi4 is available at: http://127.0.0.1:40659/g52b_wtUP5E=/
The Flutter DevTools debugger and profiler on Tizen rpi4 is available at: http://127.0.0.1:39049?uri=http://127.0.0.1:40659/g52b_wtUP5E=/

....

[E] globalapps/org.tizen.video_player_tizen_example/bin/Runner.dll: ../src/vulkan/runtime/vk_image.c:279: vk_image_expand_aspect_mask: Assertion `image->aspects & VK_IMAGE_ASPECT_ANY_COLOR_MASK_MESA' failed.

flutter/shell/platform/tizen/external_texture_surface_vulkan_buffer.cc

flutter/shell/platform/tizen/external_texture.h

flutter/shell/platform/tizen/external_texture_surface_vulkan.cc

flutter/shell/platform/tizen/tizen_renderer_vulkan.cc

flutter/shell/platform/embedder/embedder.h

JSUYA · 2025-12-05T10:14:11Z

flutter/shell/platform/tizen/external_texture_pixel_vulkan.cc

+void ExternalTexturePixelVulkan::CopyBufferToImage(const uint8_t* src_buffer,
+                                                   VkDeviceSize size) {
+  void* data;
+  vkMapMemory(GetDevice(), staging_buffer_memory_, 0, size, 0, &data);
+  memcpy(data, src_buffer, static_cast<size_t>(size));
+  vkUnmapMemory(GetDevice(), staging_buffer_memory_);
+  VkCommandBuffer command_buffer = vulkan_renderer_->BeginSingleTimeCommands();


I haven't tested webRTC. As far as I know, webRTC is the only way to test PixelBuffer. Does it work?

I have implemented a sample code for pixel buffer, it can be worked on RPI4.
However, my computer is under repair. I will upload the sample code once it's fixed.

xiaowei-guan · 2025-12-08T11:17:48Z

When I tested with video_player, app has crashed. please check it out.

plugins/packages/video_player/example (master) 17:52:58 $ flutter-tizen run --enable-impeller --dart-define=USE_FLUTTER_TIZEN_EXPERIMENTAL=true
Launching tizen/flutter/generated_main.dart on Tizen rpi4 in debug mode...
The platform profile is used for signing.
Building a Tizen application in debug mode...                      12.2s
✓ Built build/tizen/tpk/org.tizen.video_player_tizen_example-1.0.0.tpk (40.1MB)
Installing build/tizen/tpk/org.tizen.video_player_tizen_example-1.0.0.tpk...        17.8s
[E] [WARNING:flutter/impeller/renderer/backend/vulkan/driver_info_vk.cc(263)] Unknown GPU Driver Vendor: 5348. This is not an error.
[E] [IMPORTANT:flutter/shell/platform/embedder/embedder_surface_vulkan_impeller.cc(80)] Using the Impeller rendering backend (Vulkan).
Syncing files to device Tizen rpi4...                               55ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

A Dart VM Service on Tizen rpi4 is available at: http://127.0.0.1:40659/g52b_wtUP5E=/
The Flutter DevTools debugger and profiler on Tizen rpi4 is available at: http://127.0.0.1:39049?uri=http://127.0.0.1:40659/g52b_wtUP5E=/

....

[E] globalapps/org.tizen.video_player_tizen_example/bin/Runner.dll: ../src/vulkan/runtime/vk_image.c:279: vk_image_expand_aspect_mask: Assertion `image->aspects & VK_IMAGE_ASPECT_ANY_COLOR_MASK_MESA' failed.

I will update the RPI4 image and check it

1.rename texture callback parameter name. 2.add null check for vulkan texture. 3.rename PopulateOpenGLTexture to PopulateGLTexture. 4.change DRM_FORMAT to vulkan format.

…render-texture-002

xiaowei-guan · 2025-12-10T11:04:13Z

I have verified the PR on RPI4 with latest version, there will be an out-of-memory issue:

A Dart VM Service on Tizen rpi4 is available at: http://127.0.0.1:38915/8-T6wewQGS8=/
The Flutter DevTools debugger and profiler on Tizen rpi4 is available at: http://127.0.0.1:9100?uri=http://127.0.0.1:38915/8-T6wewQGS8=/
[I] lifecycle_channel.cc: AppIsResumed(37) > Sending AppLifecycleState.resumed message.
[I] tizen_window_ecore_wl2.cc: UpdateFlutterCursor(806) > UpdateFlutterCursor is not supported.
[I] external_texture_surface_vulkan.cc: PopulateVulkanTexture(108) > gpu_surface is null for texture ID: 2
[I] external_texture_surface_vulkan.cc: PopulateVulkanTexture(108) > gpu_surface is null for texture ID: 2
[I] lifecycle_channel.cc: AppIsPaused(42) > Sending AppLifecycleState.paused message.
[I] lifecycle_channel.cc: AppIsDetached(47) > Sending AppLifecycleState.detached message.
[E] globalapps/org.tizen.video_player_tizen_example/bin/Runner.dll: ../src/broadcom/vulkan/v3dv_queue.c:957: handle_cl_job: Assertion `bo_idx == submit.bo_handle_count' failed.
[E] onSigabrt called
Lost connection to device.

xiaowei-guan · 2025-12-10T11:18:11Z

When I tested with video_player, app has crashed. please check it out.

plugins/packages/video_player/example (master) 17:52:58 $ flutter-tizen run --enable-impeller --dart-define=USE_FLUTTER_TIZEN_EXPERIMENTAL=true
Launching tizen/flutter/generated_main.dart on Tizen rpi4 in debug mode...
The platform profile is used for signing.
Building a Tizen application in debug mode...                      12.2s
✓ Built build/tizen/tpk/org.tizen.video_player_tizen_example-1.0.0.tpk (40.1MB)
Installing build/tizen/tpk/org.tizen.video_player_tizen_example-1.0.0.tpk...        17.8s
[E] [WARNING:flutter/impeller/renderer/backend/vulkan/driver_info_vk.cc(263)] Unknown GPU Driver Vendor: 5348. This is not an error.
[E] [IMPORTANT:flutter/shell/platform/embedder/embedder_surface_vulkan_impeller.cc(80)] Using the Impeller rendering backend (Vulkan).
Syncing files to device Tizen rpi4...                               55ms

Flutter run key commands.
r Hot reload. 🔥🔥🔥
R Hot restart.
h List all available interactive commands.
d Detach (terminate "flutter run" but leave application running).
c Clear the screen
q Quit (terminate the application on the device).

A Dart VM Service on Tizen rpi4 is available at: http://127.0.0.1:40659/g52b_wtUP5E=/
The Flutter DevTools debugger and profiler on Tizen rpi4 is available at: http://127.0.0.1:39049?uri=http://127.0.0.1:40659/g52b_wtUP5E=/

....

[E] globalapps/org.tizen.video_player_tizen_example/bin/Runner.dll: ../src/vulkan/runtime/vk_image.c:279: vk_image_expand_aspect_mask: Assertion `image->aspects & VK_IMAGE_ASPECT_ANY_COLOR_MASK_MESA' failed.

I will update the RPI4 image and check it

I have updated the RPI4 image(tizen-10.0-unified_20251209.112952), no such issue, but I found a memory issue, I will check it.

…render-texture-002

xiaowei-guan marked this pull request as draft November 12, 2025 09:44

xiaowei-guan and others added 6 commits November 13, 2025 09:31

Support render texture for vulkan + impeller

3803bde

modify external_texture_pixel_vulkan (#6)

daf3dcd

Fix format issue

f4403ec

Fix some code review issues

8f206d3

modify_code (#7)

f9f71ef

* modify_code * Type conversion * code format

Move render texture code to experimental

78c122b

xiaowei-guan marked this pull request as ready for review November 14, 2025 09:28

xiaowei-guan requested review from JSUYA, gin7773 and seungsoo47 November 14, 2025 09:29

xiaowei-guan added 2 commits November 15, 2025 08:53

Minor refactor

8315389

1.Add GetDevice method insted of device_ variable. 2.Refactor variable name for pixel buffer. 3.Add GetMemoryFDProperty method insted of variable.

Fix build error

3b096a8

JSUYA reviewed Dec 5, 2025

View reviewed changes

xiaowei-guan added 3 commits December 9, 2025 08:49

Fix code review issues

fc9db02

1.rename texture callback parameter name. 2.add null check for vulkan texture. 3.rename PopulateOpenGLTexture to PopulateGLTexture. 4.change DRM_FORMAT to vulkan format.

Merge remote-tracking branch 'upstream/master' into support-impeller-…

1efff63

…render-texture-002

Merge remote-tracking branch 'upstream/master' into support-impeller-…

8073a4d

…render-texture-002

xiaowei-guan added 6 commits December 11, 2025 08:33

Revert flutter-tizen code

6c96ac6

Change PopulateOpenGLTexture method name to PoplateGLTexture

0012446

Merge remote-tracking branch 'upstream/master' into support-impeller-…

fd08ddd

…render-texture-002

Merge CreateImage and BindImage method

7c26364

Release tbm surface if create vk image failed

8e0617c

Done not need release image before call reset method

6317815

Support render texture for Vulkan+Impeller #129

Are you sure you want to change the base?

Support render texture for Vulkan+Impeller #129

Uh oh!

Conversation

xiaowei-guan commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xiaowei-guan commented Nov 14, 2025

Uh oh!

xiaowei-guan commented Dec 5, 2025

Uh oh!

JSUYA commented Dec 5, 2025

Uh oh!

JSUYA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JSUYA Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

xiaowei-guan Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

xiaowei-guan commented Dec 8, 2025

Uh oh!

xiaowei-guan commented Dec 10, 2025

Uh oh!

xiaowei-guan commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xiaowei-guan commented Nov 12, 2025 •

edited

Loading