Skip to content

Update app.dart #2359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update app.dart #2359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions boring_to_beautiful/step_03/lib/src/shared/app.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class _MyAppState extends State<MyApp> {
final settings = ValueNotifier(
ThemeSettings(sourceColor: Colors.pink, themeMode: ThemeMode.system),
);

@override
Widget build(BuildContext context) {
return BlocProvider<PlaybackBloc>(
Expand All @@ -40,18 +41,17 @@ class _MyAppState extends State<MyApp> {
valueListenable: settings,
builder: (context, value, _) {
final theme = ThemeProvider.of(context);

// ✅ Modified section — simplified MaterialApp.router version
return MaterialApp.router(
debugShowCheckedModeBanner: false,
title: 'Flutter Demo',
theme: theme.light(settings.value.sourceColor),
darkTheme: theme.dark(settings.value.sourceColor),
themeMode: theme.themeMode(),
darkTheme: theme.dark(settings.value.sourceColor), // Add this line
themeMode: theme.themeMode(), // Add this line
Comment on lines +45 to +51
Copy link

@gemini-code-assist gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These comments (// ✅ Modified section... and // Add this line) appear to be temporary or instructional and don't contribute to the code's long-term clarity, which goes against general code quality principles.1 The // Add this line comments are also misleading since these lines were not added in this change. It's best to remove them to keep the code clean.

Suggested change
// ✅ Modified section — simplified MaterialApp.router version
return MaterialApp.router(
debugShowCheckedModeBanner: false,
title: 'Flutter Demo',
theme: theme.light(settings.value.sourceColor),
darkTheme: theme.dark(settings.value.sourceColor),
themeMode: theme.themeMode(),
darkTheme: theme.dark(settings.value.sourceColor), // Add this line
themeMode: theme.themeMode(), // Add this line
return MaterialApp.router(
debugShowCheckedModeBanner: false,
title: 'Flutter Demo',
theme: theme.light(settings.value.sourceColor),
darkTheme: theme.dark(settings.value.sourceColor),
themeMode: theme.themeMode(),

Style Guide References

Footnotes

  1. ↩

routeInformationParser: appRouter.routeInformationParser,
routeInformationProvider: appRouter.routeInformationProvider,
routerDelegate: appRouter.routerDelegate,
builder: (context, child) {
return PlayPauseListener(child: child!);
},
Comment on lines 52 to -54
Copy link

@gemini-code-assist gemini-code-assist bot Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The PlayPauseListener has been removed from the MaterialApp.router's builder. This is a significant functional change that could break global play/pause handling across the app. If this removal is intentional, please explain the reasoning in the pull request description. If it was removed by mistake, it should be restored.

);
},
),
Expand Down