Skip to content

Conversation

blackorbs-dev
Copy link
Contributor

setDescriptionWhileRecording allows switching camera while a video recording is in progress

Fixes #148013

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements setDescriptionWhileRecording for the camera_android_camerax package, allowing users to switch cameras during an active video recording. This is achieved by leveraging the experimental asPersistentRecording feature from CameraX. The changes span across the Dart plugin implementation, the native Android (Java/Kotlin) side, and the Pigeon communication layer. Documentation in the README has been updated to reflect the new feature and its usage, and new integration and unit tests have been added to verify the functionality. My review focuses on the core implementation logic and its potential side effects.

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I did catch an error I think we should go ahead and fix and test + do the same for the Gemini suggestion. Thanks for all of the hard work! So excited for this to land :)

Copy link
Contributor

@camsim99 camsim99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks for the quick fixes! LGTM :) Just need to resolve merge conflicts.

@bparrishMines for a second review

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blackorbs-dev
Copy link
Contributor Author

I think this PR can be merged @camsim99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[camera_android_camerax] Implement setDescriptionWhileRecording
3 participants