-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[camera_android_camerax] Implement setDescriptionWhileRecording #10030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…amera platform packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request implements setDescriptionWhileRecording
for the camera_android_camerax
package, allowing users to switch cameras during an active video recording. This is achieved by leveraging the experimental asPersistentRecording
feature from CameraX. The changes span across the Dart plugin implementation, the native Android (Java/Kotlin) side, and the Pigeon communication layer. Documentation in the README has been updated to reflect the new feature and its usage, and new integration and unit tests have been added to verify the functionality. My review focuses on the core implementation logic and its potential side effects.
packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I did catch an error I think we should go ahead and fix and test + do the same for the Gemini suggestion. Thanks for all of the hard work! So excited for this to land :)
packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow thanks for the quick fixes! LGTM :) Just need to resolve merge conflicts.
@bparrishMines for a second review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think this PR can be merged @camsim99 |
setDescriptionWhileRecording allows switching camera while a video recording is in progress
Fixes #148013
Pre-Review Checklist
[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assist
bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3