[camera_android] Remove references to third party googlesamples/mlkit code
#10056
+2
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
changed the title
camsim99
changed the title
googlesamples/mlkit code
stuartmorgan-g
added
override: no versioning needed
stuartmorgan-g
approved these changes
Sep 23, 2025
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 24, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 24, 2025
flutter/packages@3413b65...117bf63 2025-09-24 magder@google.com [ci] Add update-release-info command suggestion when version check fails (flutter/packages#9834) 2025-09-24 engine-flutter-autoroll@skia.org Manual roll Flutter from 9ff2767 to 4a04204 (28 revisions) (flutter/packages#10067) 2025-09-24 stuartmorgan@google.com Remove "All right reserved" from all files (flutter/packages#10066) 2025-09-24 stuartmorgan@google.com [google_sign_in] Implement `disconnect` for Android (flutter/packages#9991) 2025-09-24 43054281+camsim99@users.noreply.github.com [camera_android] Remove references to third party `googlesamples/mlkit` code (flutter/packages#10056) 2025-09-23 52160996+FMorschel@users.noreply.github.com [go_router_builder] [in_app_purchase_storekit] Removes redundant arguments from annotations (flutter/packages#9964) 2025-09-23 121233810+nozomemein@users.noreply.github.com [go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. (flutter/packages#9868) 2025-09-23 NearTox@outlook.com [go_router_builder] Proposal: add json support, custom string encoder/decoder (flutter/packages#8665) 2025-09-23 lukas.mirbt@appshack.se [go_router] Fix ShellRoutes break iOS swipe back navigation (flutter/packages#9968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: comment-only change (Little late to the party there, test-bot!) |
Jaineel-Mamtora
pushed a commit
to Jaineel-Mamtora/flutter_forked
that referenced
this pull request
Sep 24, 2025
…r#175935) flutter/packages@3413b65...117bf63 2025-09-24 magder@google.com [ci] Add update-release-info command suggestion when version check fails (flutter/packages#9834) 2025-09-24 engine-flutter-autoroll@skia.org Manual roll Flutter from 9ff2767 to 4a04204 (28 revisions) (flutter/packages#10067) 2025-09-24 stuartmorgan@google.com Remove "All right reserved" from all files (flutter/packages#10066) 2025-09-24 stuartmorgan@google.com [google_sign_in] Implement `disconnect` for Android (flutter/packages#9991) 2025-09-24 43054281+camsim99@users.noreply.github.com [camera_android] Remove references to third party `googlesamples/mlkit` code (flutter/packages#10056) 2025-09-23 52160996+FMorschel@users.noreply.github.com [go_router_builder] [in_app_purchase_storekit] Removes redundant arguments from annotations (flutter/packages#9964) 2025-09-23 121233810+nozomemein@users.noreply.github.com [go_router] Fix Android Cold Start deep link with empty path losing scheme and authority. (flutter/packages#9868) 2025-09-23 NearTox@outlook.com [go_router_builder] Proposal: add json support, custom string encoder/decoder (flutter/packages#8665) 2025-09-23 lukas.mirbt@appshack.se [go_router] Fix ShellRoutes break iOS swipe back navigation (flutter/packages#9968) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to mlkit/android/vision-quickstart as per my findings in #10022 (comment).
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3