[various] Standardize gradle dependencies #10083
Open
+358
−297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standardizes dependencies in build.gradle files on using parentheses rather than space. This doesn't enforce this syntax via repo tool checks, since it's not critical (it just reduces future churn when switching to Kotlin), and eventually the switch to Kotlin will provide the enforcement. It does fix a latent issue where test-only dependency changes that used the () syntax wouldn't have been recognized by the tool as test-only changes for changelog/version check purposes. Part of flutter/flutter#176065
stuartmorgan-g
added
the
override: no versioning needed
stuartmorgan-g
requested review from
bparrishMines and
ash2moon
as code owners
stuartmorgan-g
added
the
override: no changelog needed
stuartmorgan-g
requested review from
gmackall,
jesswrd,
camsim99,
mboetger,
reidbaker and
tarrinneal
as code owners
github-actions
bot
added
p: pigeon
p: camera
p: espresso
p: file_selector
p: flutter_plugin_android_lifecycle
p: google_maps_flutter
p: google_sign_in
p: image_picker
p: in_app_purchase
p: local_auth
p: path_provider
p: quick_actions
platform-android
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
p: interactive_media_ads
|
CHANGELOG/version override: this is a no-op style change, so doesn't impact clients. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes Gradle dependency declarations across numerous build.gradle files to use parentheses and double quotes, aiming for better consistency and closer alignment with Kotlin syntax. The changes are widespread but mechanical. A key improvement is the update to package_state_utils.dart to correctly recognize test-only dependencies using the new parenthesis syntax, which is a valuable fix. The accompanying tests for this logic have been updated and expanded, which is great. My review found the changes to be well-executed, with just one minor typo in a test file.
reidbaker
approved these changes
Sep 26, 2025
|
|
||
| test('requires changelog or version change for other build.gradle changes', | ||
| test( | ||
| 'does not requires changelog or version change for build.gradle ' |
There was a problem hiding this comment.
Suggested change
| 'does not requires changelog or version change for build.gradle ' | |
| 'does not require changelog or version change for build.gradle ' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardizes dependencies in build.gradle files on using parentheses rather than space. Also standardizes these lines on
"rather than'while touching them, since that also moves closer to Kotlin syntax.This doesn't enforce this syntax via repo tool checks, since it's not critical (it just reduces future churn when switching to Kotlin), and eventually the switch to Kotlin will provide the enforcement.
It does fix a latent issue where test-only dependency changes that used the () syntax wouldn't have been recognized by the tool as test-only changes for changelog/version check purposes.
Part of flutter/flutter#176065
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3