[various] Standardize Gradle namespace
#10084
Conversation
Standardizes namespace on the `=` form of property assignment, and updates the existing namespace check to require that version. Also standardizes these lines on `"` rather than `'` while touching them. Part of flutter/flutter#176065
stuartmorgan-g
added
override: no versioning needed
stuartmorgan-g
requested review from
bparrishMines,
ash2moon,
gmackall,
jesswrd,
camsim99,
mboetger,
reidbaker,
domesticmouse,
tarrinneal,
Piinks,
Hixie and
chunhtai
as code owners
|
CHANGELOG/version override: this is a no-op style change, so doesn't impact clients. |
github-actions
bot
added
p: extension_google_sign_in_as_googleapis_auth
p: pigeon
p: rfw
github-actions
bot
added
p: quick_actions
platform-android
p: webview_flutter
p: video_player
p: url_launcher
p: shared_preferences
p: interactive_media_ads
| signingConfig signingConfigs.debug | ||
| } | ||
| } | ||
| namespace 'com.example.example' |
There was a problem hiding this comment.
This example app had somehow ended up with two namespaces.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request standardizes the Gradle namespace property to use the = assignment form and double quotes across numerous build.gradle files. It also updates the gradle-check tool to enforce this new convention. The changes are well-executed and improve consistency. I've found one issue in the test suite where a test case is not correctly asserting a failure, which could lead to undetected regressions.
| /// compatibility with apps that use AGP 8+. | ||
| bool _validateNamespace(RepositoryPackage package, String gradleContents, | ||
| {required bool isExample}) { | ||
| // Regex to validate that either of the following namespace definitions |
There was a problem hiding this comment.
Did you mean to delete "of"
There was a problem hiding this comment.
I meant to rewrite the sentence more than I did; I'm not sure what happened.
stuartmorgan-g
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/packages/10084, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label. |
stuartmorgan-g
added
the
autosubmit
stuartmorgan-g
changed the title
namespacenamespace
Standardizes namespace on the
=form of property assignment, and updates the existing namespace check to require that version.Also standardizes these lines on
"rather than'while touching them.Part of flutter/flutter#176065
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3