Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 7, 2025

Update CODEOWNERS for Android tests.

We'll do another rebalancing exercise soon.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CODEOWNERS file to reassign ownership for three Android packages: google_sign_in_android, quick_actions_android, and video_player_android. The owner for these packages is changed from @ash2moon to @reidbaker. The changes are consistent with the file's existing structure and formatting, including alphabetical sorting of packages and alignment of owner names. The update appears to be a straightforward administrative change as part of code ownership rebalancing, and I found no issues with the changes.

Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 11, 2025
@auto-submit auto-submit bot merged commit 71e05e1 into main Nov 11, 2025
80 checks passed
@auto-submit auto-submit bot deleted the jmagman-patch-1 branch November 11, 2025 13:15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 11, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Nov 11, 2025
flutter/packages@4cec230...7063d75

2025-11-11 31859944+LongCatIsLooong@users.noreply.github.com
[video_player_avfoundation] removes unnecessary duration and size check
before sending the initialized event (flutter/packages#9534)
2025-11-11 magder@google.com Update Android package CODEOWNERS
(flutter/packages#10386)
2025-11-11 stuartmorgan@google.com [url_launcher] Remove unused
dartHostTestHandler (flutter/packages#10324)
2025-11-11 stuartmorgan@google.com [path_provider] Remove use of
Pigeon's Dart test generator (flutter/packages#10323)
2025-11-11 stuartmorgan@google.com [image_picker] Remove use of Pigeon's
Dart test generator (flutter/packages#10320)
2025-11-11 stuartmorgan@google.com [shared_preferences] Remove use of
Pigeon's Dart test generator (flutter/packages#10325)
2025-11-10 50643541+Mairramer@users.noreply.github.com
[camera_android_camerax] Fixes crash with unsupported operation
exception (flutter/packages#10342)
2025-11-10 stuartmorgan@google.com [file_selector] Remove unused web
code (flutter/packages#10376)
2025-11-10 engine-flutter-autoroll@skia.org Manual roll Flutter from
c5e809a to 31a8481 (9 revisions) (flutter/packages#10392)
2025-11-10 danferreiradev@gmail.com [file_selector] Add
canCreateDirectories to FileDialogOptions (flutter/packages#10317)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants