Skip to content

Conversation

@robert-ancell
Copy link
Contributor

Raise awareness that Flutter FIXME:RELEASED_VERSION merged the UI/platform threads on Linux. This is a significant internal change that might break apps. If so, we'd like customers to reach out to us on GitHub so that we can fix bugs, if any.

Raise awareness that Flutter FIXME:RELEASED_VERSION merged the UI/platform threads on
Linux. This is a significant internal change that _might_
break apps. If so, we'd like customers to reach out to us on GitHub so
that we can fix bugs, if any.
@robert-ancell robert-ancell requested review from a team and sfshaza2 as code owners October 9, 2025 22:10
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @robert-ancell, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces crucial documentation to inform Flutter users about a significant internal architectural change on Linux: the merging of UI and platform threads. This modification, while standardizing behavior across platforms, has the potential to impact existing applications. The primary objective is to proactively communicate this breaking change and establish a clear channel for users to report any issues, thereby ensuring the continued stability and smooth evolution of Flutter applications on the Linux platform.

Highlights

  • Announcement of Merged Threads on Linux: This pull request adds an announcement regarding Flutter's internal change to merge UI and platform threads by default on Linux, aligning its behavior with other platforms.
  • Potential Breaking Change Awareness: The announcement highlights that this significant internal change might break existing applications and encourages users to report any regressions on GitHub to facilitate bug fixes.
  • Documentation Update: A new markdown file, linux-merged-threads.md, is added to the release/breaking-changes section, providing detailed context, a description of the change, a migration guide, and references for this threading modification.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@robert-ancell robert-ancell marked this pull request as draft October 9, 2025 22:10
@robert-ancell
Copy link
Contributor Author

This is essentially a copy of #12440

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new breaking change announcement for merged threads on Linux. The changes include adding the announcement to the index and creating a new markdown file with the details. My review focuses on consistency and adherence to the repository's documentation standards. I've pointed out a placeholder inconsistency and some sorting issues in the index file. Overall, the content of the announcement is clear and well-written.

@robert-ancell
Copy link
Contributor Author

@loic-sharma I'm not sure what version numbers to put in here - is there a number for the next release I should use or remove these numbers?

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Oct 9, 2025

Visit the preview URL for this PR (updated for commit 2ddf2a2):

https://flutter-docs-prod--pr12534-linux-merged-threads-dtnweglh.web.app

@loic-sharma
Copy link
Member

loic-sharma commented Oct 9, 2025

@robert-ancell The placeholders are fine for now :)

FYI @flutter/website-reviewers, this change (flutter/flutter#176759) is NOT in the upcoming 3.38 release. It'll land in the subsequent release.

@parlough parlough marked this pull request as ready for review November 16, 2025 17:53
@parlough
Copy link
Member

Thanks for your patience on this!

I've handled the merge conflicts and updated the version placeholders. Is this otherwise ready to land? It seems the linked PR is in the 3.39.0-0.1.pre release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants