fix(framework): Make RUNNING transition atomic across replicas#6792
Open
fix(framework): Make RUNNING transition atomic across replicas#6792
Conversation
Signed-off-by: Patrick Foley <patrick@flower.ai>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to make the STARTING -> RUNNING run-status transition safe under multi-replica contention in the SQL-based LinkState implementation, and adds concurrent tests to validate uniqueness/claim behavior across SQLite-backed replicas.
Changes:
- Add an atomic
UPDATE ... WHERE ... RETURNINGclaim path forStatus.RUNNINGtransitions inSqlLinkState.update_run_status. - Improve/standardize an error log message related to invalid
sub_statusvalues. - Add multi-threaded, multi-replica SQLite tests to ensure unique claiming of messages and the RUNNING transition.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
framework/py/flwr/server/superlink/linkstate/sql_linkstate.py |
Introduces an atomic update path for claiming STARTING -> RUNNING across replicas and adjusts an error message. |
framework/py/flwr/server/superlink/linkstate/linkstate_test.py |
Adds file-based SQLite concurrency tests to validate unique claiming under contention and atomic RUNNING transitions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Patrick Foley <patrick@flower.ai>
Signed-off-by: Patrick Foley <patrick@flower.ai>
Signed-off-by: Patrick Foley <patrick@flower.ai>
Signed-off-by: Patrick Foley <patrick@flower.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?