feat(framework): Require license file in fab_format_version=1#6825
Open
mohammadnaseri wants to merge 3 commits intomainfrom
Open
feat(framework): Require license file in fab_format_version=1#6825mohammadnaseri wants to merge 3 commits intomainfrom
fab_format_version=1#6825mohammadnaseri wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens FAB format v1 validation by requiring apps to declare a root-level license file via [project].license.file and by verifying that the declared license file is actually present in the filtered FAB contents during build.
Changes:
- Add v1 validation for
[project].license.file(must beLICENSEorLICENSE.md) and reject inline license text. - Add v1 build-time contents validation to ensure the declared license file is included in the final FAB.
- Extend unit tests to cover the new v1 license requirements and FAB build behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
framework/py/flwr/supercore/fab_format_version.py |
Implements v1 license declaration parsing/validation and checks declared license file is included in filtered FAB paths. |
framework/py/flwr/supercore/fab_format_version_test.py |
Updates existing v1 tests for the new requirement and adds new unit tests for license validation rules. |
framework/py/flwr/cli/build_test.py |
Updates v1 build tests to include a license file and adds new build tests to assert missing/excluded license behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an additional check to
fab_format_version = 1validation by requiring apps to declare a root-level license file in[project].license.fileand ensuring that the declared file is actually included in the final FAB.