feat(TimberDynamicResize): delete resized images when image is deleted #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timber Dynamic Resize in Flynt uses a custom folder “resized” using the filter timber/image/new_path dynamically within the generateImage function to store the resized images, but it does not change the path for images that are resized with the native Timber resize() function and keeps the native behaviour.
The changes are build on top on this approach so that resized images in the custom “resized“ folder are deleted after the original image was deleted.
Further resized images are not getting deleted when deleting an image if they are generated in a separate directory using the filter timber/image/new_path – created a PR to make this possible.