Merged
Conversation
fmalatino
approved these changes
Mar 27, 2025
fmalatino
requested changes
Mar 27, 2025
| fieldname: str, | ||
| data_shape: list[int], | ||
| data_type: Any, | ||
| is_in: int | None = None, |
Owner
There was a problem hiding this comment.
Maybe use Optional[int] = None instead
Collaborator
Author
There was a problem hiding this comment.
I will change the "optional" arguments to be is_in : int = None.
| raise RuntimeError("Data_override, datatype not supported") | ||
|
|
||
| ndata = np.prod(data_shape) | ||
|
|
Owner
There was a problem hiding this comment.
Why not use the data_handling module?
Collaborator
Author
There was a problem hiding this comment.
The data_handling module is outdated and could be more pythonic such as,
data_c, data_t = convert(types.c_int, data)
They will be upgraded and used throughout.
Owner
There was a problem hiding this comment.
Can you add that as an issue so we can track and assign it?
Collaborator
Author
|
ready for review again. I made some additional changes such as removing |
fmalatino
approved these changes
Mar 28, 2025
mlee03
pushed a commit
to mlee03/pyFMS_old
that referenced
this pull request
Apr 21, 2025
data_overide_3d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in data_override_3d