Merged
Conversation
Collaborator
|
Is this PR a draft because it was waiting for cFMS? |
Owner
Author
Yes. Once 26 is merged in cFMS I will update this one and open it for review. |
mlee03
requested changes
Apr 15, 2025
| @pytest.mark.parallel | ||
| def test_update_domains(): | ||
|
|
||
| NX = 8 |
Collaborator
There was a problem hiding this comment.
These don't need to be capitalized. They were capitalized in cFMS because they wre defined as macros.
| ) | ||
|
|
||
| if mpp.pe() == 0: | ||
| assert idata[ix][iy] == answers[0][ix][iy] |
Collaborator
There was a problem hiding this comment.
I am not following this assert here. is it only checking for rank 0,.. for a value of ix and iy? It should check for all ranks and for alll array elements
mlee03
reviewed
Apr 15, 2025
| nhalo=nhalo, | ||
| ) | ||
|
|
||
| for ix in range(xsize_d): |
mlee03
reviewed
Apr 15, 2025
|
|
||
| for ix in range(xsize_d): | ||
| for iy in range(ysize_d): | ||
| if mpp.pe() == 0: |
Collaborator
There was a problem hiding this comment.
you need to test for all pe's
mlee03
approved these changes
Apr 16, 2025
mlee03
pushed a commit
to mlee03/pyFMS_old
that referenced
this pull request
Apr 21, 2025
Feature/mpp/update_domains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR brings in the
update_domainsmethod from cFMS.How Has This Been Tested?
Tested using Python port of existing unit test in cFMS,
test_update_domainsChecklist: