Multidimensional parameters, default=1. #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galfthan
reviewed
May 17, 2019
Member
galfthan
left a comment
galfthan
left a comment
There was a problem hiding this comment.
For me the changes look sane. I assume they have been tested
Contributor
Author
|
Yes, this was tested with the new DROs of Vlasiator. |
Contributor
|
For as long as a vectorsize=1 parameter written with the new function can be read using readParameter, there shouldn't be any conflicts with other code. |
Contributor
|
Also a new function should be added for reading the multidimensional parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If e.g. a vector of floats is passed as
&vector[0]this goes smoothly and a PARAMETER of more than 1 scalar is written successfully using Vlasiator.With the default value of 1 this does not break anything at least in Vlasiator.
Open for discussion here or on Flowdock, in particular I'd like @sandroos' comments.