-
-
Notifications
You must be signed in to change notification settings - Fork 341
Code quality #1466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
trueqbit
wants to merge
15
commits into
dev
Choose a base branch
from
clang-related
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Code quality #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Temporarily disable spurious Clang warnings instead of suppressing them in code. * Clang understands C++26 even in C++17 mode, but it doesn't mean it understands other language features, so we need to be specific using them. * Removed a few unused type aliases in UTs. * Addressed a few warnings about unused variables. * Needed to disable the rtree module example because Clang chokes on using constexpr variables in lambdas.
clang is using libstd++ by default and chokes when including <chrono>.
fnc12
approved these changes
Nov 25, 2025
… image" This reverts commit 7577c9c.
The "Ubuntu" tagged worker image is now an alias for Ubuntu2204. We still want to stay at the older toolchain in order to catch buggy compiler behavior.
fnc12
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Visual C++ 18 2026 as well as Clang 21 are out. In an attempt to compile sqlite_orm with these new toolchains I corrected and improved things along the way.
Fixes:
operator"" _cte()->operator""_cte().Generic improvements:
static_assert, which was not possible with C++14 before.Clang related:
Clang MSVC: