feat: robust Wish binary detection with version parsing#87
Open
Esubaalew wants to merge 1 commit intofodydev:mainfrom
Open
feat: robust Wish binary detection with version parsing#87Esubaalew wants to merge 1 commit intofodydev:mainfrom
Esubaalew wants to merge 1 commit intofodydev:mainfrom
Conversation
Improve Wish frontend initialization by adding robust detection of the Wish binary: - Added `wish_parse_version` to extract numeric versions from Wish binary names. - Added `wish_sort_and_dedupe_bins` to sort by version descending and remove duplicate paths. - Added `wish_fallback_candidates` for reliable fallback binaries if PATH scan fails. - Updated `init()` to scan PATH and environment variables (WISH_BIN / AFRISH_WISH_BIN) before falling back. - Added unit tests for parsing, sorting, and fallback functions. This ensures Afrim Wish selects the highest available Wish version, supports custom paths, and gives clear error messages when no valid binary is found.
Member
|
In case the system don't have a good which version, the user can use his own through a shell command like I think it's a better approach since, the installer of Between, the correct place for what you are trying to do is at https://github.com/fodydev/afrish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Wish frontend initialization by adding robust detection of the Wish binary:
wish_parse_versionto extract numeric versions from Wish binary names.wish_sort_and_dedupe_binsto sort by version descending and remove duplicate paths.wish_fallback_candidatesfor reliable fallback binaries if PATH scan fails.init()to scan PATH and environment variables (WISH_BIN / AFRISH_WISH_BIN) before falling back.This ensures Afrim Wish selects the highest available Wish version, supports custom paths, and gives clear error messages when no valid binary is found.