-
Notifications
You must be signed in to change notification settings - Fork 25
UIMPROF-108 Adjust R1 2025 app order #3310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: R1-2025
Are you sure you want to change the base?
Conversation
zburke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds three libraries that are not part of package.json. They need to be present in both or removed here. I think removal is correct but we should confirm with somebody who knows more about the Sunflower release than I, either from Kitfox-DevOps or Petrenko.
- @folio/inn-reach
- @folio/oa
- @folio/requests-mediated
A fourth,
- @folio/stripes-inventory-components
I'm confident is just a shared library and should certainly be removed here. There's no harm in it, but including it here could be misleading.
…hould be omitted from config.
…form-complete into R1-2025-app-order
zburke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@JohnC-80 , this PR will become less important once we apps are sorted by display-name when folio-org/stripes-core#1617 and folio-org/stripes-core#1619 released. Do you think we should keep it because the extra comments in |
This PR reorders visible apps to alphabetical order by their display name - this will place them in alphabetical order when someone 'resets to default' in "My profile" > "Application display order" settings.