Skip to content

Conversation

@JohnC-80
Copy link

@JohnC-80 JohnC-80 commented Apr 3, 2025

This PR reorders visible apps to alphabetical order by their display name - this will place them in alphabetical order when someone 'resets to default' in "My profile" > "Application display order" settings.

@JohnC-80 JohnC-80 requested a review from zburke April 3, 2025 16:29
@JohnC-80 JohnC-80 changed the title Adjust R1 2025 app order UIMPROF-108 Adjust R1 2025 app order Apr 3, 2025
Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds three libraries that are not part of package.json. They need to be present in both or removed here. I think removal is correct but we should confirm with somebody who knows more about the Sunflower release than I, either from Kitfox-DevOps or Petrenko.

  • @folio/inn-reach
  • @folio/oa
  • @folio/requests-mediated

A fourth,

  • @folio/stripes-inventory-components

I'm confident is just a shared library and should certainly be removed here. There's no harm in it, but including it here could be misleading.

@JohnC-80
Copy link
Author

JohnC-80 commented Apr 4, 2025

@zburke Adding/taking away should definitely be off the menu for this PR... testing with an install/build. This was honestly just taken from the work over on #3219 and I checked for any omissions, but not for additions.

Copy link
Member

@zburke zburke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zburke
Copy link
Member

zburke commented Apr 8, 2025

@JohnC-80 , this PR will become less important once we apps are sorted by display-name when folio-org/stripes-core#1617 and folio-org/stripes-core#1619 released. Do you think we should keep it because the extra comments in stripes.config.js about apps vs plugins etc are nice to have, or just close it because "extra comments" isn't good enough justification for a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants